Conversation
|
Review status: 0 of 94 files reviewed at latest revision, 9 unresolved discussions. a discussion (no related file): In the future, try to organize your Git repo so it's clear which files are important. The txt files with the lyrics in them should be placed in a "data" folder, and the unused python files should be either deleted or placed in a "misc" folder. Please remember to delete unused code as you go, so it's easier to debug and remember which components of the code are important at any given time. Typically, functions are defined together at the top of the file, then the necessary functions are called one by one in order under an "if name == main" conditional at the end of the file. This keeps important components together, increasing readability. All in all, good job. Looking forward to seeing what you come up with in the future. :) kpop_lyrics.py, line 28 [r1] (raw file): kpop_lyrics.py, line 30 [r1] (raw file): kpop_lyrics.py, line 33 [r1] (raw file): kpop_lyrics.py, line 47 [r1] (raw file): kpop_lyrics.py, line 63 [r1] (raw file): kpop_lyrics.py, line 64 [r1] (raw file): kpop_lyrics.py, line 65 [r1] (raw file): kpop_lyrics.py, line 82 [r1] (raw file): Comments from Reviewable |
I'm sorry this was turned in at 2:00 not 12:00
The important ones are kpop.py,kpop_lyrics.py, frequency, and Project Statement